From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([184.105.139.130]:50490 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750725AbeBVS6l (ORCPT ); Thu, 22 Feb 2018 13:58:41 -0500 Date: Thu, 22 Feb 2018 13:58:39 -0500 (EST) Message-Id: <20180222.135839.2197107822845062302.davem@davemloft.net> To: dsahern@gmail.com Cc: jiri@resnulli.us, netdev@vger.kernel.org, idosch@mellanox.com, mlxsw@mellanox.com Subject: Re: [patch net-next] mlxsw: spectrum_switchdev: Allow port enslavement to a VLAN-unaware bridge From: David Miller In-Reply-To: References: <20180220074512.4307-1-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: David Ahern Date: Wed, 21 Feb 2018 11:16:35 -0700 > On 2/20/18 12:45 AM, Jiri Pirko wrote: >> From: Ido Schimmel >> >> Up until now we only allowed VLAN devices to be put in a VLAN-unaware >> bridge, but some users need the ability to enslave physical ports as >> well. >> >> This is achieved by mapping the port and VID 1 to the bridge's vFID, >> instead of the port and the VID used by the VLAN device. >> >> The above is valid because as long as the port is not enslaved to a >> bridge, VID 1 is guaranteed to be configured as PVID and egress >> untagged. >> >> Signed-off-by: Ido Schimmel >> Signed-off-by: Jiri Pirko >> --- >> drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 12 +++++------- >> 1 file changed, 5 insertions(+), 7 deletions(-) >> > > Maybe I am missing something in the setup, but I am not getting > host-to-host connectivity. I booted a switch with this patch, configured > a bridge: I'm waiting for this discussion to be fully resolved before applying this patch. Just FYI...