From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, steve.glendinning@shawell.net
Subject: Re: [PATCH net] smsc75xx: fix smsc75xx_set_features()
Date: Thu, 22 Feb 2018 14:05:26 -0500 (EST) [thread overview]
Message-ID: <20180222.140526.540412089618526073.davem@davemloft.net> (raw)
In-Reply-To: <1519191746.55655.34.camel@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 20 Feb 2018 21:42:26 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> If an attempt is made to disable RX checksums, USB adapter is changed
> but netdev->features is not, because smsc75xx_set_features() returns a
> non zero value.
>
> This throws errors from netdev_rx_csum_fault() :
> <devname>: hw csum failure
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Steve Glendinning <steve.glendinning@shawell.net>
Applied, thanks Eric.
prev parent reply other threads:[~2018-02-22 19:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 5:42 [PATCH net] smsc75xx: fix smsc75xx_set_features() Eric Dumazet
2018-02-22 19:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180222.140526.540412089618526073.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).