From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([184.105.139.130]:50580 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750776AbeBVTF2 (ORCPT ); Thu, 22 Feb 2018 14:05:28 -0500 Date: Thu, 22 Feb 2018 14:05:26 -0500 (EST) Message-Id: <20180222.140526.540412089618526073.davem@davemloft.net> To: eric.dumazet@gmail.com Cc: netdev@vger.kernel.org, steve.glendinning@shawell.net Subject: Re: [PATCH net] smsc75xx: fix smsc75xx_set_features() From: David Miller In-Reply-To: <1519191746.55655.34.camel@gmail.com> References: <1519191746.55655.34.camel@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: Eric Dumazet Date: Tue, 20 Feb 2018 21:42:26 -0800 > From: Eric Dumazet > > If an attempt is made to disable RX checksums, USB adapter is changed > but netdev->features is not, because smsc75xx_set_features() returns a > non zero value. > > This throws errors from netdev_rx_csum_fault() : > : hw csum failure > > Signed-off-by: Eric Dumazet > Cc: Steve Glendinning Applied, thanks Eric.