From: David Miller <davem@davemloft.net>
To: keescook@google.com
Cc: tgraf@suug.ch, johannes@sipsolutions.net, daniel@iogearbox.net,
ast@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, danielmicay@gmail.com
Subject: Re: nla_put_string() vs NLA_STRING
Date: Thu, 22 Feb 2018 14:07:04 -0500 (EST) [thread overview]
Message-ID: <20180222.140704.166412303524863230.davem@davemloft.net> (raw)
In-Reply-To: <CAGXu5jLg62737XeB3g0SOLTz-7NyF6_MvvH69kqFE4iqX2w7vQ@mail.gmail.com>
From: Kees Cook <keescook@google.com>
Date: Tue, 20 Feb 2018 22:00:26 -0800
> So, this specific problem needs fixing (in at least two places calling
> nla_put_string(msg, NL80211_ATTR_REG_ALPHA2, ...)). While I suspect
> it's only ever written an extra byte from the following variable in
> the structure which is an enum nl80211_dfs_regions, I worry there
> might be a lot more of these (though I'd hope unterminated strings are
> uncommon for internal representation). And more generally, it seems
> like only the NLA _input_ functions actually check nla_policy details.
> It seems that the output functions should do the same too, yes?
Generally speaking, the policy is for making sure the user doesn't
give us garbage.
When building netlink attributes itself, the kernel is supposed to
know what it is doing.
next prev parent reply other threads:[~2018-02-22 19:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 6:00 nla_put_string() vs NLA_STRING Kees Cook
2018-02-22 19:07 ` David Miller [this message]
2018-02-22 19:54 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180222.140704.166412303524863230.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=danielmicay@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=keescook@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).