* [PATCH] net/smc9194: Remove bogus CONFIG_MAC reference
@ 2018-02-21 22:24 Finn Thain
2018-02-22 19:45 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Finn Thain @ 2018-02-21 22:24 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev, linux-m68k, linux-kernel
AFAIK the only version of smc9194.c with Mac support is the one in the
linux-mac68k CVS repo, which never made it to the mainline.
Despite that, from v2.3.45, arch/m68k/config.in listed CONFIG_SMC9194
under CONFIG_MAC. This mistake got carried over into Kconfig in v2.5.55.
(See pre-git era "[PATCH] add m68k dependencies to net driver config".)
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
---
drivers/net/ethernet/smsc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/smsc/Kconfig b/drivers/net/ethernet/smsc/Kconfig
index 63aca9f847e1..4c2f612e4414 100644
--- a/drivers/net/ethernet/smsc/Kconfig
+++ b/drivers/net/ethernet/smsc/Kconfig
@@ -20,7 +20,7 @@ if NET_VENDOR_SMSC
config SMC9194
tristate "SMC 9194 support"
- depends on (ISA || MAC && BROKEN)
+ depends on ISA
select CRC32
---help---
This is support for the SMC9xxx based Ethernet cards. Choose this
--
2.16.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/smc9194: Remove bogus CONFIG_MAC reference
2018-02-21 22:24 [PATCH] net/smc9194: Remove bogus CONFIG_MAC reference Finn Thain
@ 2018-02-22 19:45 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-02-22 19:45 UTC (permalink / raw)
To: fthain; +Cc: netdev, linux-m68k, linux-kernel
From: Finn Thain <fthain@telegraphics.com.au>
Date: Thu, 22 Feb 2018 09:24:59 +1100 (AEDT)
> AFAIK the only version of smc9194.c with Mac support is the one in the
> linux-mac68k CVS repo, which never made it to the mainline.
>
> Despite that, from v2.3.45, arch/m68k/config.in listed CONFIG_SMC9194
> under CONFIG_MAC. This mistake got carried over into Kconfig in v2.5.55.
> (See pre-git era "[PATCH] add m68k dependencies to net driver config".)
>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-22 19:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-21 22:24 [PATCH] net/smc9194: Remove bogus CONFIG_MAC reference Finn Thain
2018-02-22 19:45 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).