From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:51710 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750842AbeBVUeD (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 22 Feb 2018 15:34:03 -0500
Date: Thu, 22 Feb 2018 15:34:00 -0500 (EST)
Message-Id: <20180222.153400.848754057860912740.davem@davemloft.net>
To: dan.carpenter@oracle.com
Cc: igor.russkikh@aquantia.com, weiyongjun1@huawei.com,
        pavel.belous@aquantia.com, darcari@redhat.com,
        netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net] net: aquantia: Fix error handling in aq_pci_probe()
From: David Miller <davem@davemloft.net>
In-Reply-To: <20180222091155.GA9883@mwanda>
References: <20180222091155.GA9883@mwanda>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 22 Feb 2018 12:11:55 +0300

> We should check "self->aq_hw" for allocation failure, and also we should
> free it on the error paths.
> 
> Fixes: 23ee07ad3c2f ("net: aquantia: Cleanup pci functions module")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied, thanks Dan.