From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:35176 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751707AbeBWR3m (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 23 Feb 2018 12:29:42 -0500
Date: Fri, 23 Feb 2018 12:29:41 -0500 (EST)
Message-Id: <20180223.122941.321660111864248315.davem@davemloft.net>
To: hkallweit1@gmail.com
Cc: nic_swsd@realtek.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] r8169: simplify and improve check for dash
From: David Miller <davem@davemloft.net>
In-Reply-To: <b6bb8535-640b-beb4-282f-128edd08ab48@gmail.com>
References: <b6bb8535-640b-beb4-282f-128edd08ab48@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Thu, 22 Feb 2018 21:37:48 +0100

> r8168_check_dash() returns false anyway for all chip versions not
> supporting dash. So we can simplify the check conditions.
> 
> In addition change the check functions to return bool instead of int,
> because they actually return a bool value.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Applied.