From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, john.fastabend@gmail.com,
xiyou.wangcong@gmail.com, jhs@mojatatu.com, jiri@resnulli.us
Subject: Re: [PATCH v2 net] net_sched: gen_estimator: fix broken estimators based on percpu stats
Date: Fri, 23 Feb 2018 12:43:30 -0500 (EST) [thread overview]
Message-ID: <20180223.124330.1637118557891234954.davem@davemloft.net> (raw)
In-Reply-To: <1519357527.55655.66.camel@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 22 Feb 2018 19:45:27 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> pfifo_fast got percpu stats lately, uncovering a bug I introduced last
> year in linux-4.10.
>
> I missed the fact that we have to clear our temporary storage
> before calling __gnet_stats_copy_basic() in the case of percpu stats.
>
> Without this fix, rate estimators (tc qd replace dev xxx root est 1sec
> 4sec pfifo_fast) are utterly broken.
>
> Fixes: 1c0d32fde5bd ("net_sched: gen_estimator: complete rewrite of rate estimators")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
> v2: Perform the zeroing in est_fetch_counters() instead of caller(s)
Applied and queued up for -stable.
prev parent reply other threads:[~2018-02-23 17:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 3:36 [PATCH net] net_sched: gen_estimator: fix broken estimators based on percpu stats Eric Dumazet
2018-02-23 3:40 ` Eric Dumazet
2018-02-23 3:45 ` [PATCH v2 " Eric Dumazet
2018-02-23 17:43 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180223.124330.1637118557891234954.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).