From: David Miller <davem@davemloft.net>
To: ganeshgr@chelsio.com
Cc: netdev@vger.kernel.org, leedom@chelsio.com,
nirranjan@chelsio.com, indranil@chelsio.com,
venkatesh@chelsio.com, arjun@chelsio.com
Subject: Re: [PATCH net-next] cxgb4vf: Forcefully link up virtual interfaces
Date: Fri, 23 Feb 2018 12:45:29 -0500 (EST) [thread overview]
Message-ID: <20180223.124529.33988764914477795.davem@davemloft.net> (raw)
In-Reply-To: <1519398413-10461-1-git-send-email-ganeshgr@chelsio.com>
From: Ganesh Goudar <ganeshgr@chelsio.com>
Date: Fri, 23 Feb 2018 20:36:53 +0530
> @@ -92,6 +92,18 @@ module_param(msi, int, 0644);
> MODULE_PARM_DESC(msi, "whether to use MSI-X or MSI");
>
> /*
> + * Logic controls.
> + * ===============
> + */
> +
> +/* The Virtual Interfaces are connected to an internal switch on the chip
> + * which allows VIs attached to the same port to talk to each other even when
> + * the port link is down. As a result, we generally want to always report a
> + * VI's link as being "up".
> + */
> +#define force_link_up 1
Please don't do this, just perform the actions unconditionally.
prev parent reply other threads:[~2018-02-23 17:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 15:06 [PATCH net-next] cxgb4vf: Forcefully link up virtual interfaces Ganesh Goudar
2018-02-23 17:45 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180223.124529.33988764914477795.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arjun@chelsio.com \
--cc=ganeshgr@chelsio.com \
--cc=indranil@chelsio.com \
--cc=leedom@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=nirranjan@chelsio.com \
--cc=venkatesh@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).