From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:35554 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751632AbeBWRpa (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 23 Feb 2018 12:45:30 -0500
Date: Fri, 23 Feb 2018 12:45:29 -0500 (EST)
Message-Id: <20180223.124529.33988764914477795.davem@davemloft.net>
To: ganeshgr@chelsio.com
Cc: netdev@vger.kernel.org, leedom@chelsio.com, nirranjan@chelsio.com,
        indranil@chelsio.com, venkatesh@chelsio.com, arjun@chelsio.com
Subject: Re: [PATCH net-next] cxgb4vf: Forcefully link up virtual interfaces
From: David Miller <davem@davemloft.net>
In-Reply-To: <1519398413-10461-1-git-send-email-ganeshgr@chelsio.com>
References: <1519398413-10461-1-git-send-email-ganeshgr@chelsio.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Ganesh Goudar <ganeshgr@chelsio.com>
Date: Fri, 23 Feb 2018 20:36:53 +0530

> @@ -92,6 +92,18 @@ module_param(msi, int, 0644);
>  MODULE_PARM_DESC(msi, "whether to use MSI-X or MSI");
>  
>  /*
> + * Logic controls.
> + * ===============
> + */
> +
> +/* The Virtual Interfaces are connected to an internal switch on the chip
> + * which allows VIs attached to the same port to talk to each other even when
> + * the port link is down.  As a result, we generally want to always report a
> + * VI's link as being "up".
> + */
> +#define force_link_up 1

Please don't do this, just perform the actions unconditionally.