From: David Miller <davem@davemloft.net>
To: batuhanosmantaskaya@gmail.com
Cc: netdev@vger.kernel.org, batuhan@gmail.com
Subject: Re: [PATCH 1/1] Linux Traffic Control (tc) unit testing suite's code quality improved, String formattings updated. According to python documentation "The built-in string class provides the ability to do complex variable substitutions and value formatting via the format() method described in PEP 3101. " but the project was using old type formattings and new type string formattings together. This patch's purpose is converting other old-type-string formattings to new type string formattings in Linux Traffic Control Unit Testing Suit.
Date: Fri, 23 Feb 2018 13:50:52 -0500 (EST) [thread overview]
Message-ID: <20180223.135052.1020621904894938943.davem@davemloft.net> (raw)
In-Reply-To: <20180223184830.22125-1-batuhanosmantaskaya@gmail.com>
From: BTaskaya <batuhanosmantaskaya@gmail.com>
Date: Fri, 23 Feb 2018 21:48:30 +0300
> Signed-off-by: Batuhan Osman Taskaya <batuhan@gmail.com>
Sorry, this still is not submitted properly.
You Subject line is enormous. It should contain a short,
concise, title for the change. Including subsystem prefixes,
followed by a colon character, and a space, then the
title text.
The rest belongs in the commit message proper, and thus the
message body.
I asked you quite politely to look at how other people submit
patches properly on this mailing list, so that you could observe,
learn, and see how it is supposed to look.
If you had done so, we wouldn't have to go back and forth like
this.
So please take my polite suggestion seriously.
Thank you.
next prev parent reply other threads:[~2018-02-23 18:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 18:48 [PATCH 1/1] Linux Traffic Control (tc) unit testing suite's code quality improved, String formattings updated. According to python documentation "The built-in string class provides the ability to do complex variable substitutions and value formatting via the format() method described in PEP 3101. " but the project was using old type formattings and new type string formattings together. This patch's purpose is converting other old-type-string formattings to new type string formattings in Linux Traffic Control Unit Testing Suit BTaskaya
2018-02-23 18:50 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-02-23 17:35 BTaskaya
2018-02-23 17:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180223.135052.1020621904894938943.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=batuhan@gmail.com \
--cc=batuhanosmantaskaya@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).