From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([184.105.139.130]:36414 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935623AbeBWS4g (ORCPT ); Fri, 23 Feb 2018 13:56:36 -0500 Date: Fri, 23 Feb 2018 13:50:52 -0500 (EST) Message-Id: <20180223.135052.1020621904894938943.davem@davemloft.net> To: batuhanosmantaskaya@gmail.com Cc: netdev@vger.kernel.org, batuhan@gmail.com Subject: Re: [PATCH 1/1] Linux Traffic Control (tc) unit testing suite's code quality improved, String formattings updated. According to python documentation "The built-in string class provides the ability to do complex variable substitutions and value formatting via the format() method described in PEP 3101. " but the project was using old type formattings and new type string formattings together. This patch's purpose is converting other old-type-string formattings to new type string formattings in Linux Traffic Control Unit Testing Suit. From: David Miller In-Reply-To: <20180223184830.22125-1-batuhanosmantaskaya@gmail.com> References: <20180223184830.22125-1-batuhanosmantaskaya@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: BTaskaya Date: Fri, 23 Feb 2018 21:48:30 +0300 > Signed-off-by: Batuhan Osman Taskaya Sorry, this still is not submitted properly. You Subject line is enormous. It should contain a short, concise, title for the change. Including subsystem prefixes, followed by a colon character, and a space, then the title text. The rest belongs in the commit message proper, and thus the message body. I asked you quite politely to look at how other people submit patches properly on this mailing list, so that you could observe, learn, and see how it is supposed to look. If you had done so, we wouldn't have to go back and forth like this. So please take my polite suggestion seriously. Thank you.