From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f68.google.com ([209.85.160.68]:40072 "EHLO
        mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751656AbeBWQn0 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 23 Feb 2018 11:43:26 -0500
Received: by mail-pl0-f68.google.com with SMTP id i6so5186733plt.7
        for <netdev@vger.kernel.org>; Fri, 23 Feb 2018 08:43:25 -0800 (PST)
Date: Fri, 23 Feb 2018 08:33:23 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Masatake YAMATO <yamato@redhat.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2] ss: prepare rth when killing inet sock
Message-ID: <20180223083323.6c6db1bf@xeon-e3>
In-Reply-To: <20180215191120.16176-1-yamato@redhat.com>
References: <20180215191120.16176-1-yamato@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri, 16 Feb 2018 04:11:20 +0900
Masatake YAMATO <yamato@redhat.com> wrote:

> kill_inet_sock() expects rhn_handle instance is passed
> via inet_diag_arg argument. However on the following calling path:
> 
>     generic_show_sock
>     => show_one_inet_sock
>        => kill_inet_sock  
> 
> rth field of inet_diag_arg is not filled with the address of
> rhn_handle instance. As the result ss crashes.
> 
> This commit fills the field with newly created rhn_handle
> instance.
> 
> Changes in v2:
> Instead of creating rtn_handle instances for each socket, create
> one in upper layer and reuse it.
> 
> Signed-off-by: Masatake YAMATO <yamato@redhat.com>

Applied.
Thanks for following through.