From: Stephen Hemminger <stephen@networkplumber.org>
To: Arkadi Sharshevsky <arkadis@mellanox.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
dsa@cumulusnetworks.com, mlxsw@mellanox.com
Subject: Re: [PATCH iproute2 6/7] devlink: Add support for resource/dpipe relation
Date: Fri, 23 Feb 2018 08:40:17 -0800 [thread overview]
Message-ID: <20180223084017.07066dd7@xeon-e3> (raw)
In-Reply-To: <1518598522-27713-7-git-send-email-arkadis@mellanox.com>
On Wed, 14 Feb 2018 10:55:21 +0200
Arkadi Sharshevsky <arkadis@mellanox.com> wrote:
> @@ -3457,15 +3509,36 @@ static int dpipe_table_show(struct dpipe_ctx *ctx, struct nlattr *nl)
> return -EINVAL;
> }
>
> - name = mnl_attr_get_str(nla_table[DEVLINK_ATTR_DPIPE_TABLE_NAME]);
> + table = dpipe_table_alloc();
> + if (!table)
> + return -ENOMEM;
> +
> + table->name = strdup(mnl_attr_get_str(nla_table[DEVLINK_ATTR_DPIPE_TABLE_NAME]));
> size = mnl_attr_get_u32(nla_table[DEVLINK_ATTR_DPIPE_TABLE_SIZE]);
> counters_enabled = !!mnl_attr_get_u8(nla_table[DEVLINK_ATTR_DPIPE_TABLE_COUNTERS_ENABLED]);
The use of long variable names in devlink is making for very long lines.
Please consider adopting a more concise style in future revisions.
Je n’ai fait celle-ci plus longue que parce que je n’ai pas eu le loisir de la faire plus courte.
next prev parent reply other threads:[~2018-02-23 16:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 8:55 [PATCH iproute2 0/7] Add support for devlink resource abstraction Arkadi Sharshevsky
2018-02-14 8:55 ` [PATCH iproute2 1/7] devlink: Change empty line indication with indentations Arkadi Sharshevsky
2018-02-14 15:11 ` Stephen Hemminger
2018-02-14 15:17 ` Jiri Pirko
2018-02-14 8:55 ` [PATCH iproute2 2/7] devlink: mnlg: Add support for extended ack Arkadi Sharshevsky
2018-02-14 15:12 ` Stephen Hemminger
2018-02-15 11:57 ` Arkadi Sharshevsky
2018-02-15 18:15 ` Stephen Hemminger
2018-02-14 8:55 ` [PATCH iproute2 3/7] devlink: Add support for devlink resource abstraction Arkadi Sharshevsky
2018-02-14 8:55 ` [PATCH iproute2 4/7] devlink: Add support for hot reload Arkadi Sharshevsky
2018-02-14 8:55 ` [PATCH iproute2 5/7] devlink: Move dpipe context from heap to stack Arkadi Sharshevsky
2018-02-14 8:55 ` [PATCH iproute2 6/7] devlink: Add support for resource/dpipe relation Arkadi Sharshevsky
2018-02-23 16:40 ` Stephen Hemminger [this message]
2018-02-14 8:55 ` [PATCH iproute2 7/7] devlink: Update man pages and add resource man Arkadi Sharshevsky
2018-02-15 3:41 ` [PATCH iproute2 0/7] Add support for devlink resource abstraction David Ahern
2018-02-22 10:19 ` Arkadi Sharshevsky
2018-02-22 15:02 ` David Ahern
2018-02-23 16:41 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180223084017.07066dd7@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=arkadis@mellanox.com \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox