From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f46.google.com ([209.85.160.46]:41529 "EHLO mail-pl0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751762AbeBWQkV (ORCPT ); Fri, 23 Feb 2018 11:40:21 -0500 Received: by mail-pl0-f46.google.com with SMTP id k8so5182215pli.8 for ; Fri, 23 Feb 2018 08:40:21 -0800 (PST) Date: Fri, 23 Feb 2018 08:40:17 -0800 From: Stephen Hemminger To: Arkadi Sharshevsky Cc: netdev@vger.kernel.org, davem@davemloft.net, dsa@cumulusnetworks.com, mlxsw@mellanox.com Subject: Re: [PATCH iproute2 6/7] devlink: Add support for resource/dpipe relation Message-ID: <20180223084017.07066dd7@xeon-e3> In-Reply-To: <1518598522-27713-7-git-send-email-arkadis@mellanox.com> References: <1518598522-27713-1-git-send-email-arkadis@mellanox.com> <1518598522-27713-7-git-send-email-arkadis@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 14 Feb 2018 10:55:21 +0200 Arkadi Sharshevsky wrote: > @@ -3457,15 +3509,36 @@ static int dpipe_table_show(struct dpipe_ctx *ctx= , struct nlattr *nl) > return -EINVAL; > } > =20 > - name =3D mnl_attr_get_str(nla_table[DEVLINK_ATTR_DPIPE_TABLE_NAME]); > + table =3D dpipe_table_alloc(); > + if (!table) > + return -ENOMEM; > + > + table->name =3D strdup(mnl_attr_get_str(nla_table[DEVLINK_ATTR_DPIPE_TA= BLE_NAME])); > size =3D mnl_attr_get_u32(nla_table[DEVLINK_ATTR_DPIPE_TABLE_SIZE]); > counters_enabled =3D !!mnl_attr_get_u8(nla_table[DEVLINK_ATTR_DPIPE_TAB= LE_COUNTERS_ENABLED]); The use of long variable names in devlink is making for very long lines. Please consider adopting a more concise style in future revisions. Je n=E2=80=99ai fait celle-ci plus longue que parce que je n=E2=80=99ai pas= eu le loisir de la faire plus courte.