From: Stephen Hemminger <stephen@networkplumber.org>
To: Donald Sharp <sharpd@cumulusnetworks.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 v2] ip: Properly display AF_BRIDGE address information for neighbor events
Date: Fri, 23 Feb 2018 11:28:57 -0800 [thread overview]
Message-ID: <20180223112857.58a36d32@xeon-e3> (raw)
In-Reply-To: <20180223191009.13286-1-sharpd@cumulusnetworks.com>
On Fri, 23 Feb 2018 14:10:09 -0500
Donald Sharp <sharpd@cumulusnetworks.com> wrote:
> The vxlan driver when a neighbor add/delete event occurs sends
> NDA_DST filled with a union:
>
> union vxlan_addr {
> struct sockaddr_in sin;
> struct sockaddr_in6 sin6;
> struct sockaddr sa;
> };
>
> This eventually calls rt_addr_n2a_r which had no handler for the
> AF_BRIDGE family and "???" was being printed.
>
> Add code to properly display this data when requested.
>
> Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
I did some minor changes to the patch and applied it.
(need space after switch, and can don't need local variable family).
Thanks.
prev parent reply other threads:[~2018-02-23 19:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 2:26 [PATCH iproute2] ip: Properly display AF_BRIDGE address information for neighbor events Donald Sharp
2018-02-23 16:28 ` Stephen Hemminger
2018-02-23 19:10 ` [PATCH iproute2 v2] " Donald Sharp
2018-02-23 19:28 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180223112857.58a36d32@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=sharpd@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).