From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f176.google.com ([209.85.192.176]:36840 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753928AbeBWT3A (ORCPT ); Fri, 23 Feb 2018 14:29:00 -0500 Received: by mail-pf0-f176.google.com with SMTP id 68so3918330pfx.3 for ; Fri, 23 Feb 2018 11:29:00 -0800 (PST) Date: Fri, 23 Feb 2018 11:28:57 -0800 From: Stephen Hemminger To: Donald Sharp Cc: netdev@vger.kernel.org Subject: Re: [PATCH iproute2 v2] ip: Properly display AF_BRIDGE address information for neighbor events Message-ID: <20180223112857.58a36d32@xeon-e3> In-Reply-To: <20180223191009.13286-1-sharpd@cumulusnetworks.com> References: <20180222022650.14316-1-sharpd@cumulusnetworks.com> <20180223191009.13286-1-sharpd@cumulusnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 23 Feb 2018 14:10:09 -0500 Donald Sharp wrote: > The vxlan driver when a neighbor add/delete event occurs sends > NDA_DST filled with a union: > > union vxlan_addr { > struct sockaddr_in sin; > struct sockaddr_in6 sin6; > struct sockaddr sa; > }; > > This eventually calls rt_addr_n2a_r which had no handler for the > AF_BRIDGE family and "???" was being printed. > > Add code to properly display this data when requested. > > Signed-off-by: Donald Sharp I did some minor changes to the patch and applied it. (need space after switch, and can don't need local variable family). Thanks.