netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: David Ahern <dsahern@gmail.com>
Cc: kbuild-all@01.org, netdev@vger.kernel.org, idosch@idosch.org,
	tom@herbertland.com, davem@davemloft.net,
	roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com,
	David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH net-next 6/7] mlxsw: spectrum_router: Add support for ipv6 hash policy update
Date: Sat, 24 Feb 2018 01:09:47 +0800	[thread overview]
Message-ID: <201802240103.ProaL017%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180221184954.28875-7-dsahern@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1913 bytes --]

Hi David,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/David-Ahern/net-ipv6-Add-support-for-path-selection-using-hash-of-5-tuple/20180222-222437
config: x86_64-randconfig-u0-02240002 (attached as .config)
compiler: gcc-5 (Debian 5.5.0-3) 5.4.1 20171010
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c: In function 'mlxsw_sp_mp6_hash_init':
>> drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c:7027:26: error: 'struct net' has no member named 'ipv6'
     bool only_l3 = !init_net.ipv6.sysctl.multipath_hash_policy;
                             ^

vim +7027 drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c

  7024	
  7025	static void mlxsw_sp_mp6_hash_init(char *recr2_pl)
  7026	{
> 7027		bool only_l3 = !init_net.ipv6.sysctl.multipath_hash_policy;
  7028	
  7029		mlxsw_sp_mp_hash_header_set(recr2_pl,
  7030					    MLXSW_REG_RECR2_IPV6_EN_NOT_TCP_NOT_UDP);
  7031		mlxsw_sp_mp_hash_header_set(recr2_pl, MLXSW_REG_RECR2_IPV6_EN_TCP_UDP);
  7032		mlxsw_reg_recr2_ipv6_sip_enable(recr2_pl);
  7033		mlxsw_reg_recr2_ipv6_dip_enable(recr2_pl);
  7034		mlxsw_sp_mp_hash_field_set(recr2_pl, MLXSW_REG_RECR2_IPV6_NEXT_HEADER);
  7035		if (only_l3) {
  7036			mlxsw_sp_mp_hash_field_set(recr2_pl, MLXSW_REG_RECR2_IPV6_FLOW_LABEL);
  7037		} else {
  7038			mlxsw_sp_mp_hash_header_set(recr2_pl, MLXSW_REG_RECR2_TCP_UDP_EN_IPV6);
  7039			mlxsw_sp_mp_hash_field_set(recr2_pl, MLXSW_REG_RECR2_TCP_UDP_SPORT);
  7040			mlxsw_sp_mp_hash_field_set(recr2_pl, MLXSW_REG_RECR2_TCP_UDP_DPORT);
  7041		}
  7042	}
  7043	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29556 bytes --]

  parent reply	other threads:[~2018-02-23 17:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-21 18:49 [PATCH net-next 0/7] net/ipv6: Add support for path selection using hash of 5-tuple David Ahern
2018-02-21 18:49 ` [PATCH net-next 1/7] net/ipv4: Pass net to fib_multipath_hash instead of fib_info David Ahern
2018-02-21 18:49 ` [PATCH net-next 2/7] net: Align ip_multipath_l3_keys and ip6_multipath_l3_keys David Ahern
2018-02-21 18:49 ` [PATCH net-next 3/7] net/ipv6: Make rt6_multipath_hash similar to fib_multipath_hash David Ahern
2018-02-21 18:49 ` [PATCH net-next 4/7] net: Rename NETEVENT_MULTIPATH_HASH_UPDATE David Ahern
2018-02-21 18:49 ` [PATCH net-next 5/7] net/ipv6: Add support for path selection using hash of 5-tuple David Ahern
2018-02-22 10:09   ` Ido Schimmel
2018-02-21 18:49 ` [PATCH net-next 6/7] mlxsw: spectrum_router: Add support for ipv6 hash policy update David Ahern
2018-02-21 20:26   ` Ido Schimmel
2018-02-22 12:54   ` Ido Schimmel
2018-02-23 17:09   ` kbuild test robot [this message]
2018-02-21 18:49 ` [PATCH net-next 7/7] net: Remove unused get_hash_from_flow functions David Ahern
2018-02-22 19:27 ` [PATCH net-next 0/7] net/ipv6: Add support for path selection using hash of 5-tuple David Miller
2018-02-22 19:31   ` David Ahern
2018-02-22 19:40     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201802240103.ProaL017%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=idosch@idosch.org \
    --cc=kbuild-all@01.org \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=roopa@cumulusnetworks.com \
    --cc=tom@herbertland.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).