From: Matthew Wilcox <willy@infradead.org>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-mm@kvack.org,
ikomyagin@gmail.com, Stephen Hemminger <sthemmin@microsoft.com>,
Christoph Lameter <cl@linux.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH 0/2] mark some slabs as visible not mergeable
Date: Sat, 24 Feb 2018 13:05:07 -0800 [thread overview]
Message-ID: <20180224210507.GA28183@bombadil.infradead.org> (raw)
In-Reply-To: <20180224190454.23716-1-sthemmin@microsoft.com>
On Sat, Feb 24, 2018 at 11:04:52AM -0800, Stephen Hemminger wrote:
> This fixes an old bug in iproute2's ss command because it was
> reading slabinfo to get statistics. There isn't a better API
> to do this, and one can argue that /proc is a UAPI that must
> not change.
>
> Therefore this patch set adds a flag to slab to give another
> reason to prevent merging, and then uses it in network code.
This is exactly the solution I would have suggested. Note that SLUB
has always had slab merging, so this tool has been broken since 2.6.22
on any kernel with CONFIG_SLUB.
Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2018-02-24 21:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-24 19:04 [PATCH 0/2] mark some slabs as visible not mergeable Stephen Hemminger
2018-02-24 19:04 ` [PATCH 1/2] slab: add flag to block merging of UAPI elements Stephen Hemminger
2018-02-24 19:04 ` [PATCH 2/2] net: mark slab's used by ss as UAPI Stephen Hemminger
2018-02-25 3:34 ` kbuild test robot
2018-02-25 6:05 ` [net] ba4f5b62a2: kernel_BUG_at_net/socket.c kernel test robot
2018-02-24 21:05 ` Matthew Wilcox [this message]
2018-02-25 16:36 ` [PATCH 0/2] mark some slabs as visible not mergeable Stephen Hemminger
2018-02-26 20:15 ` David Miller
2018-02-26 21:46 ` Stephen Hemminger
2018-02-27 1:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180224210507.GA28183@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=cl@linux.com \
--cc=davem@davemloft.net \
--cc=iamjoonsoo.kim@lge.com \
--cc=ikomyagin@gmail.com \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).