From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: emil.s.tantilov@intel.com, netdev@vger.kernel.org,
nhorman@redhat.com, sassmann@redhat.com, jogreene@redhat.com,
stable@vger.kernel.org
Subject: Re: [net] ixgbe: fix crash in build_skb Rx code path
Date: Mon, 26 Feb 2018 13:47:49 -0500 (EST) [thread overview]
Message-ID: <20180226.134749.1372103055616948220.davem@davemloft.net> (raw)
In-Reply-To: <20180223203941.3193-1-jeffrey.t.kirsher@intel.com>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Fri, 23 Feb 2018 12:39:41 -0800
> From: Emil Tantilov <emil.s.tantilov@intel.com>
>
> Add check for build_skb enabled ring in ixgbe_dma_sync_frag().
> In that case &skb_shinfo(skb)->frags[0] may not always be set which
> can lead to a crash. Instead we derive the page offset from skb->data.
>
> Fixes: 42073d91a214
> ("ixgbe: Have the CPU take ownership of the buffers sooner")
> CC: stable <stable@vger.kernel.org>
> Reported-by: Ambarish Soman <asoman@redhat.com>
> Suggested-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
> Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied, thanks Jeff.
prev parent reply other threads:[~2018-02-26 18:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 20:39 [net] ixgbe: fix crash in build_skb Rx code path Jeff Kirsher
2018-02-26 18:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180226.134749.1372103055616948220.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=emil.s.tantilov@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jogreene@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).