From: David Miller <davem@davemloft.net>
To: jasowang@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
mst@redhat.com, sergei.shtylyov@cogentembedded.com,
christoffer.dall@linaro.org, brouer@redhat.com
Subject: Re: [PATCH V4 net 1/3] Revert "tuntap: add missing xdp flush"
Date: Mon, 26 Feb 2018 13:50:04 -0500 (EST) [thread overview]
Message-ID: <20180226.135004.744356947488629833.davem@davemloft.net> (raw)
In-Reply-To: <1519443146-9089-1-git-send-email-jasowang@redhat.com>
From: Jason Wang <jasowang@redhat.com>
Date: Sat, 24 Feb 2018 11:32:24 +0800
> This reverts commit 762c330d670e3d4b795cf7a8d761866fdd1eef49. The
> reason is we try to batch packets for devmap which causes calling
> xdp_do_flush() in the process context. Simply disabling preemption
> may not work since process may move among processors which lead
> xdp_do_flush() to miss some flushes on some processors.
>
> So simply revert the patch, a follow-up patch will add the xdp flush
> correctly.
>
> Reported-by: Christoffer Dall <christoffer.dall@linaro.org>
> Fixes: 762c330d670e ("tuntap: add missing xdp flush")
> Signed-off-by: Jason Wang <jasowang@redhat.com>
Applied.
prev parent reply other threads:[~2018-02-26 18:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-24 3:32 [PATCH V4 net 1/3] Revert "tuntap: add missing xdp flush" Jason Wang
2018-02-24 3:32 ` [PATCH V4 net 2/3] tuntap: disable preemption during XDP processing Jason Wang
2018-02-26 11:02 ` Jesper Dangaard Brouer
2018-02-26 13:43 ` Jason Wang
2018-02-26 18:50 ` David Miller
2018-02-24 3:32 ` [PATCH V4 net 3/3] tuntap: correctly add the missing XDP flush Jason Wang
2018-02-26 18:50 ` David Miller
2018-02-26 18:50 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180226.135004.744356947488629833.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=brouer@redhat.com \
--cc=christoffer.dall@linaro.org \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).