From: David Miller <davem@davemloft.net>
To: hkallweit1@gmail.com
Cc: nic_swsd@realtek.com, romieu@fr.zoreil.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2] r8169: improve interrupt handling
Date: Mon, 26 Feb 2018 13:56:22 -0500 (EST) [thread overview]
Message-ID: <20180226.135622.1205217981314568094.davem@davemloft.net> (raw)
In-Reply-To: <7f1cbc71-9d2d-627f-9e0e-b7e7b1f6ce9b@gmail.com>
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Sat, 24 Feb 2018 16:53:23 +0100
> @@ -736,8 +736,7 @@ struct ring_info {
> };
>
> enum features {
> - RTL_FEATURE_MSI = (1 << 0),
> - RTL_FEATURE_GMII = (1 << 1),
> + RTL_FEATURE_GMII = (1 << 0),
> };
>
> struct rtl8169_counters {
...
> + if (tp->mac_version <= RTL_GIGA_MAC_VER_06) {
Please, if you are going to keep the logic the same for the older
chips, just keep the RTL_FEATURE_MSI flag around instead of adding
new (and potentially regression causing) tests for this condition.
Thank you.
next prev parent reply other threads:[~2018-02-26 18:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-24 15:53 [PATCH net-next v2] r8169: improve interrupt handling Heiner Kallweit
2018-02-26 18:56 ` David Miller [this message]
2018-02-26 19:50 ` Heiner Kallweit
2018-02-27 16:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180226.135622.1205217981314568094.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).