From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:45698 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751175AbeBZS4Y (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 26 Feb 2018 13:56:24 -0500
Date: Mon, 26 Feb 2018 13:56:22 -0500 (EST)
Message-Id: <20180226.135622.1205217981314568094.davem@davemloft.net>
To: hkallweit1@gmail.com
Cc: nic_swsd@realtek.com, romieu@fr.zoreil.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2] r8169: improve interrupt handling
From: David Miller <davem@davemloft.net>
In-Reply-To: <7f1cbc71-9d2d-627f-9e0e-b7e7b1f6ce9b@gmail.com>
References: <7f1cbc71-9d2d-627f-9e0e-b7e7b1f6ce9b@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Sat, 24 Feb 2018 16:53:23 +0100

> @@ -736,8 +736,7 @@ struct ring_info {
>  };
>  
>  enum features {
> -	RTL_FEATURE_MSI		= (1 << 0),
> -	RTL_FEATURE_GMII	= (1 << 1),
> +	RTL_FEATURE_GMII	= (1 << 0),
>  };
>  
>  struct rtl8169_counters {
 ...
> +	if (tp->mac_version <= RTL_GIGA_MAC_VER_06) {

Please, if you are going to keep the logic the same for the older
chips, just keep the RTL_FEATURE_MSI flag around instead of adding
new (and potentially regression causing) tests for this condition.

Thank you.