From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([184.105.139.130]:45800 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751343AbeBZTFq (ORCPT ); Mon, 26 Feb 2018 14:05:46 -0500 Date: Mon, 26 Feb 2018 14:05:44 -0500 (EST) Message-Id: <20180226.140544.1684161543332531356.davem@davemloft.net> To: dsahern@gmail.com Cc: netdev@vger.kernel.org, idosch@idosch.org, roopa@cumulusnetworks.com, eric.dumazet@gmail.com, weiwan@google.com, kafai@fb.com, yoshfuji@linux-ipv6.org Subject: Re: [PATCH RFC net-next 01/20] net: Move fib_convert_metrics to dst core From: David Miller In-Reply-To: <20180225194730.30063-2-dsahern@gmail.com> References: <20180225194730.30063-1-dsahern@gmail.com> <20180225194730.30063-2-dsahern@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: David Ahern Date: Sun, 25 Feb 2018 11:47:11 -0800 > diff --git a/net/core/dst.c b/net/core/dst.c > index 007aa0b08291..5f70bc832bec 100644 > --- a/net/core/dst.c > +++ b/net/core/dst.c ... > + val = tcp_ca_get_key_by_name(net, tmp, &ecn_ca); > + if (val == TCP_CA_UNSPEC) > + return -EINVAL; This makes the networking core depend upon CONFIG_INET. You will have to untangle this somehow before your final submission. Probably with an inline helper in the non-INET case that always returns TCP_CA_UNSPEC.