From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mx3-rdu2.redhat.com ([66.187.233.73]:58666 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1751411AbeBZUWG (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 26 Feb 2018 15:22:06 -0500
Date: Mon, 26 Feb 2018 15:22:05 -0500 (EST)
Message-Id: <20180226.152205.1019314339567047877.davem@redhat.com>
To: dsahern@gmail.com
Cc: netdev@vger.kernel.org, idosch@idosch.org,
        roopa@cumulusnetworks.com, eric.dumazet@gmail.com,
        weiwan@google.com, kafai@fb.com, yoshfuji@linux-ipv6.org
Subject: Re: [PATCH RFC net-next 08/20] net/ipv6: Defer initialization of
 dst to data path
From: David Miller <davem@redhat.com>
In-Reply-To: <16936451-6fbc-d498-0d51-63d43d899edf@gmail.com>
References: <20180225194730.30063-9-dsahern@gmail.com>
        <20180226.141713.1695207134632325977.davem@davemloft.net>
        <16936451-6fbc-d498-0d51-63d43d899edf@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: David Ahern <dsahern@gmail.com>
Date: Mon, 26 Feb 2018 13:20:27 -0700

> +static void ip6_rt_init_dst(struct rt6_info *rt, struct rt6_info *ort)
> +{
> +	if (ort->rt6i_flags & RTF_REJECT) {
> +		ip6_rt_init_dst_reject(rt, ort);
> +		return;
> +	}
> +
> +	rt->dst.error = 0;
> +	rt->dst.output = ip6_output;
> +
> +...
> 
> So for reject routes we have the above helper which is basically a code
> move from ip6_route_info_create.
> 
> For non-reject routes dst.error is 0 which is the rest of ip6_rt_init_dst.

My bad, thanks for explaining things to me.  The flag bit test above
completely escaped my eyes for some reason. :)