From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:58874 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932135AbeBZU3b (ORCPT ); Mon, 26 Feb 2018 15:29:31 -0500 Date: Mon, 26 Feb 2018 15:29:30 -0500 (EST) Message-Id: <20180226.152930.2200592176841409220.davem@redhat.com> To: dsahern@gmail.com Cc: netdev@vger.kernel.org, idosch@idosch.org, roopa@cumulusnetworks.com, eric.dumazet@gmail.com, weiwan@google.com, kafai@fb.com, yoshfuji@linux-ipv6.org Subject: Re: [PATCH RFC net-next 16/20] net/ipv6: Cleanup exception route handling From: David Miller In-Reply-To: <4271dfc0-4f94-d14d-18b9-ea06831bde95@gmail.com> References: <20180225194730.30063-17-dsahern@gmail.com> <20180226.142746.1107269119562830375.davem@davemloft.net> <4271dfc0-4f94-d14d-18b9-ea06831bde95@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: David Ahern Date: Mon, 26 Feb 2018 13:25:37 -0700 > Anyways, because rt6_info is used for both FIB and dst the lookup > functions can overload the rt6_info variable usually called 'rt'. This > patch introduces a new 'f6i' variable name for the result of the FIB > lookup and keeps 'rt' as the dst based return variable. 'f6i' becomes a > fib6_info in patch 19 which is why it is introduced as 'struct rt6_info > *f6i' now; avoids the additional churn in patch 19. This I understand. :) Adjust this commit message to include some of this text and I'm happy. BTW, I love patch #20, those edits must have been fun to make :-)