From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:59244 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752130AbeBZUeQ (ORCPT ); Mon, 26 Feb 2018 15:34:16 -0500 Date: Mon, 26 Feb 2018 15:34:15 -0500 (EST) Message-Id: <20180226.153415.1078585316493629955.davem@redhat.com> To: dsahern@gmail.com Cc: netdev@vger.kernel.org, idosch@idosch.org, roopa@cumulusnetworks.com, eric.dumazet@gmail.com, weiwan@google.com, kafai@fb.com, yoshfuji@linux-ipv6.org Subject: Re: [PATCH RFC net-next 02/20] vrf: Move fib6_table into net_vrf From: David Miller In-Reply-To: <6d697655-31e9-4f82-fdda-ae7f489f5955@gmail.com> References: <20180225194730.30063-3-dsahern@gmail.com> <20180226.140832.2168046240961864572.davem@davemloft.net> <6d697655-31e9-4f82-fdda-ae7f489f5955@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: David Ahern Date: Mon, 26 Feb 2018 13:13:24 -0700 > On 2/26/18 12:08 PM, David Miller wrote: >> From: David Ahern >> Date: Sun, 25 Feb 2018 11:47:12 -0800 >> >>> A later patch removes rt6i_table from rt6_info. Save the ipv6 >>> table for a VRF in net_vrf. fib tables can not be deleted so >>> no reference counting or locking is required. >>> >>> Signed-off-by: David Ahern >> >> Is this change really OK all by itself? > > should. When you look at references to rt6i_table the only one for the > data path is changing sernum when inserting an exception. Exceptions are > not relevant for this special VRF dst as it is used for an internal > redirection before packets leave the box. ... > But if you want me to be extra cautious I can leave the rt6i_table > setting and remove it in patch 20 (remove unneeded rt6_info elements). No, it's not necessary if it is really an isolated object like this.