From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f44.google.com ([74.125.83.44]:40115 "EHLO
        mail-pg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751993AbeBZSGq (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 26 Feb 2018 13:06:46 -0500
Received: by mail-pg0-f44.google.com with SMTP id g2so6472091pgn.7
        for <netdev@vger.kernel.org>; Mon, 26 Feb 2018 10:06:46 -0800 (PST)
Date: Mon, 26 Feb 2018 10:06:38 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Serhey Popovych <serhe.popovych@gmail.com>
Cc: netdev@vger.kernel.org, dsahern@gmail.com
Subject: Re: [PATCH iproute2-next v3 8/8] iplink: Reduce number of arguments
 to iplink_parse()
Message-ID: <20180226100638.789a770d@xeon-e3>
In-Reply-To: <1519304526-18848-9-git-send-email-serhe.popovych@gmail.com>
References: <1519304526-18848-1-git-send-email-serhe.popovych@gmail.com>
        <1519304526-18848-9-git-send-email-serhe.popovych@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, 22 Feb 2018 15:02:06 +0200
Serhey Popovych <serhe.popovych@gmail.com> wrote:

> +struct iplink_parse_args {
> +	const char *dev;
> +	const char *name;
> +	const char *type;
> +
> +	/* This definitely must be the last one and initialized
> +	 * by the caller of iplink_parse() that will initialize rest.
> +	 */
> +	struct iplink_req *req;
> +};
> +

No control block please.
If you have too many arguments, then that means you need to do
some refactoring.