From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Jacob Keller <jacob.e.keller@intel.com>,
netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
jogreene@redhat.com, Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 03/13] ixgbe: prevent ptp_rx_hang from running when in FILTER_ALL mode
Date: Mon, 26 Feb 2018 10:07:46 -0800 [thread overview]
Message-ID: <20180226180756.10736-4-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <20180226180756.10736-1-jeffrey.t.kirsher@intel.com>
From: Jacob Keller <jacob.e.keller@intel.com>
On hardware which supports timestamping all packets, the timestamps are
recorded in the packet buffer, and the driver no longer uses or reads
the registers. This makes the logic for checking and clearing Rx
timestamp hangs meaningless.
If we run the ixgbe_ptp_rx_hang() function in this case, then the driver
will continuously spam the log output with "Clearing Rx timestamp hang".
These messages are spurious, and confusing to end users.
The original code in commit a9763f3cb54c ("ixgbe: Update PTP to support
X550EM_x devices", 2015-12-03) did have a flag PTP_RX_TIMESTAMP_IN_REGISTER
which was intended to be used to avoid the Rx timestamp hang check,
however it did not actually check the flag before calling the function.
Do so now in order to stop the checks and prevent the spurious log
messages.
Fixes: a9763f3cb54c ("ixgbe: Update PTP to support X550EM_x devices", 2015-12-03)
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index 0da5aa2c8aba..b032091022a8 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -7703,7 +7703,8 @@ static void ixgbe_service_task(struct work_struct *work)
if (test_bit(__IXGBE_PTP_RUNNING, &adapter->state)) {
ixgbe_ptp_overflow_check(adapter);
- ixgbe_ptp_rx_hang(adapter);
+ if (adapter->flags & IXGBE_FLAG_RX_HWTSTAMP_IN_REGISTER)
+ ixgbe_ptp_rx_hang(adapter);
ixgbe_ptp_tx_hang(adapter);
}
--
2.14.3
next prev parent reply other threads:[~2018-02-26 18:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 18:07 [net-next 00/13][pull request] 10GbE Intel Wired LAN Driver Updates 2018-02-26 Jeff Kirsher
2018-02-26 18:07 ` [net-next 01/13] ixgbe: remove redundant initialization of 'pool' Jeff Kirsher
2018-02-26 18:07 ` [net-next 02/13] ixgbe: Avoid to write the RETA table when unnecessary Jeff Kirsher
2018-02-26 18:07 ` Jeff Kirsher [this message]
2018-02-26 18:07 ` [net-next 04/13] ixgbevf: use page_address offset from page Jeff Kirsher
2018-02-26 18:07 ` [net-next 05/13] ixgbevf: add ethtool private flag for legacy Rx Jeff Kirsher
2018-02-26 18:07 ` [net-next 06/13] ixgbevf: add support for using order 1 pages to receive large frames Jeff Kirsher
2018-02-26 18:07 ` [net-next 07/13] ixgbevf: setup queue counts Jeff Kirsher
2018-02-26 18:07 ` [net-next 08/13] ixgbevf: add support for padding packet Jeff Kirsher
2018-02-26 18:07 ` [net-next 09/13] ixgbevf: make sure all frames fit minimum size requirements Jeff Kirsher
2018-02-26 18:07 ` [net-next 10/13] ixgbevf: allocate the rings as part of q_vector Jeff Kirsher
2018-02-26 18:07 ` [net-next 11/13] ixgbevf: break out Rx buffer page management Jeff Kirsher
2018-02-26 18:07 ` [net-next 12/13] ixgbevf: add build_skb support Jeff Kirsher
2018-02-26 18:07 ` [net-next 13/13] ixgbevf: remove redundant initialization of variable 'dma' Jeff Kirsher
2018-02-27 1:59 ` [net-next 00/13][pull request] 10GbE Intel Wired LAN Driver Updates 2018-02-26 David Miller
2018-02-27 21:29 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180226180756.10736-4-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=jacob.e.keller@intel.com \
--cc=jogreene@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).