From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: netdev@vger.kernel.org, arkadis@mellanox.com, mlxsw@mellanox.com
Subject: Re: [patch net] devlink: Compare to size_new in case of resource child validation
Date: Tue, 27 Feb 2018 10:53:36 -0500 (EST) [thread overview]
Message-ID: <20180227.105336.161722008755188850.davem@davemloft.net> (raw)
In-Reply-To: <20180226095953.7214-1-jiri@resnulli.us>
From: Jiri Pirko <jiri@resnulli.us>
Date: Mon, 26 Feb 2018 10:59:53 +0100
> From: Arkadi Sharshevsky <arkadis@mellanox.com>
>
> The current implementation checks the combined size of the children with
> the 'size' of the parent. The correct behavior is to check the combined
> size vs the pending change and to compare vs the 'size_new'.
>
> Fixes: d9f9b9a4d05f ("devlink: Add support for resource abstraction")
> Signed-off-by: Arkadi Sharshevsky <arkadis@mellanox.com>
> Tested-by: Yuval Mintz <yuvalm@mellanox.com>
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Applied, thank you.
prev parent reply other threads:[~2018-02-27 15:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 9:59 [patch net] devlink: Compare to size_new in case of resource child validation Jiri Pirko
2018-02-27 15:53 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180227.105336.161722008755188850.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arkadis@mellanox.com \
--cc=jiri@resnulli.us \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).