From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:57078 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753304AbeB0Pxi (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 27 Feb 2018 10:53:38 -0500
Date: Tue, 27 Feb 2018 10:53:36 -0500 (EST)
Message-Id: <20180227.105336.161722008755188850.davem@davemloft.net>
To: jiri@resnulli.us
Cc: netdev@vger.kernel.org, arkadis@mellanox.com, mlxsw@mellanox.com
Subject: Re: [patch net] devlink: Compare to size_new in case of resource
 child validation
From: David Miller <davem@davemloft.net>
In-Reply-To: <20180226095953.7214-1-jiri@resnulli.us>
References: <20180226095953.7214-1-jiri@resnulli.us>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Jiri Pirko <jiri@resnulli.us>
Date: Mon, 26 Feb 2018 10:59:53 +0100

> From: Arkadi Sharshevsky <arkadis@mellanox.com>
> 
> The current implementation checks the combined size of the children with
> the 'size' of the parent. The correct behavior is to check the combined
> size vs the pending change and to compare vs the 'size_new'.
> 
> Fixes: d9f9b9a4d05f ("devlink: Add support for resource abstraction")
> Signed-off-by: Arkadi Sharshevsky <arkadis@mellanox.com>
> Tested-by: Yuval Mintz <yuvalm@mellanox.com>
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>

Applied, thank you.