From: David Miller <davem@davemloft.net>
To: tlfalcon@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org, jallen@linux.vnet.ibm.com,
nfont@linux.vnet.ibm.com
Subject: Re: [PATCH 0/5 net-next] ibmvnic: Miscellaneous driver fixes and enhancements
Date: Tue, 27 Feb 2018 14:31:37 -0500 (EST) [thread overview]
Message-ID: <20180227.143137.2086154618936386109.davem@davemloft.net> (raw)
In-Reply-To: <1519690259-27102-1-git-send-email-tlfalcon@linux.vnet.ibm.com>
From: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
Date: Mon, 26 Feb 2018 18:10:54 -0600
> There is not a general theme to this patch set other than that it
> fixes a few issues with the ibmvnic driver. I will just give a quick
> summary of what each patch does here.
>
> "ibmvnic: Fix TX descriptor tracking again" resolves a race condition
> introduced in an earlier fix to track outstanding transmit descriptors.
> This condition can throw off the tracking counter to the point that
> a transmit queue will halt forever.
>
> "ibmvnic: Allocate statistics buffers during probe" allocates queue
> statistics buffers on device probe to avoid a crash when accessing
> statistics of an unopened interface.
>
> "ibmvnic: Harden TX/RX pool cleaning" includes additional checks to
> avoid a bad access when cleaning RX and TX buffer pools during a device
> reset.
>
> "ibmvnic: Report queue stops and restarts as debug output" changes TX
> queue state notifications from informational to debug messages. This
> information is not necessarily useful to a user and under load can result
> in a lot of log output.
>
> "ibmvnic: Do not attempt to login if RX or TX queues are not allocated"
> checks that device queues have been allocated successfully before
> attempting device login. This resolves a panic that could occur if a
> user attempted to configure a device after a failed reset.
>
> Thanks for your attention.
Series applied, thanks Thomas.
prev parent reply other threads:[~2018-02-27 19:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 0:10 [PATCH 0/5 net-next] ibmvnic: Miscellaneous driver fixes and enhancements Thomas Falcon
2018-02-27 0:10 ` [PATCH 1/5 net-next] ibmvnic: Fix TX descriptor tracking again Thomas Falcon
2018-02-27 0:10 ` [PATCH 2/5 net-next] ibmvnic: Allocate statistics buffers during probe Thomas Falcon
2018-02-27 0:10 ` [PATCH 3/5 net-next] ibmvnic: Harden TX/RX pool cleaning Thomas Falcon
2018-02-27 0:10 ` [PATCH 4/5 net-next] ibmvnic: Report queue stops and restarts as debug output Thomas Falcon
2018-02-27 0:10 ` [PATCH 5/5 net-next] ibmvnic: Do not attempt to login if RX or TX queues are not allocated Thomas Falcon
2018-02-27 19:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180227.143137.2086154618936386109.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jallen@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nfont@linux.vnet.ibm.com \
--cc=tlfalcon@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).