From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tycho Andersen Subject: Re: [net-next v3 1/2] bpf, seccomp: Add eBPF filter capabilities Date: Mon, 26 Feb 2018 20:57:46 -0700 Message-ID: <20180227035746.vh5mw7ijbyg3mbq3@cisco> References: <20180226072702.GA27057@ircssh-2.c.rugged-nimbus-611.internal> <20180227005446.cmwsmh3fz4vhimmt@smitten> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Will Drewry , Kees Cook , Daniel Borkmann , netdev , Linux Containers , Alexei Starovoitov , Andy Lutomirski To: Sargun Dhillon Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: netdev.vger.kernel.org On Mon, Feb 26, 2018 at 07:49:48PM -0800, Sargun Dhillon wrote: > On Mon, Feb 26, 2018 at 4:54 PM, Tycho Andersen wrote: > > On Mon, Feb 26, 2018 at 07:27:05AM +0000, Sargun Dhillon wrote: > >> +config SECCOMP_FILTER_EXTENDED > >> + bool "Extended BPF seccomp filters" > >> + depends on SECCOMP_FILTER && BPF_SYSCALL > >> + depends on !CHECKPOINT_RESTORE > > > > Why not just give -EINVAL or something in case one of these is > > requested, instead of making them incompatible at compile time? > > > > Tycho > There's already code to return -EMEDIUMTYPE if it's a non-classic, or > non-saved filter. Under the normal case, with CHECKPOINT_RESTORE > enabled, you should never be able to get that. I think it makes sense > to preserve this behaviour. Oh, right. So can't we just drop this, and the existing code will DTRT, i.e. give you -EMEDIUMTYPE because the new filters aren't supported, until they are? Tycho