From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from vps0.lunn.ch ([185.16.172.187]:38891 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753133AbeB0OHN (ORCPT ); Tue, 27 Feb 2018 09:07:13 -0500 Date: Tue, 27 Feb 2018 15:07:07 +0100 From: Andrew Lunn To: Gregory CLEMENT Cc: David Miller , netdev , Vivien Didelot , Gregory Clement Subject: Re: [PATCH 0/2] mv88e6xxx: Poll when no interrupt defined Message-ID: <20180227140707.GA31805@lunn.ch> References: <1519336713-5417-1-git-send-email-andrew@lunn.ch> <87lgfelohp.fsf@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87lgfelohp.fsf@bootlin.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Feb 27, 2018 at 11:24:02AM +0100, Gregory CLEMENT wrote: > Hi Andrew, > > On jeu., f�vr. 22 2018, Andrew Lunn wrote: > > > Not all boards using the mv88e6xxx switches have the interrupt output > > connected to a GPIO. On these boards phylib has to poll the PHYs, > > rather than use interrupts. Have the driver poll the interrupt status > > register, which is more efficient than having phylib do it. And it > > enables other switch interrupts to be services. > > > > The Armada 370RD is such a board without a interrupt GPIO. Now that > > interrupts work, wire up the PHYs to make use if them. > > > > Gregory: Are you O.K. for the second patch to go through netdev? > > Why do you need that the second patch to go through netdev. Is there any > dependency between the 2 patches? > > If it is the case does it means that an new kernel won't work with an > old device tree? Hi Gregory There is a runtime dependency between the two. A new device tree blob will not run on an old kernel. So if you take the second patch alone via mvebu, the PHYs will stop working, no link up reported. But an old blob will run on a new kernel. Backwards compatibility is maintained. Andrew