Re: [PATCH net-next 0/2] ntuple filters with RSS

Re: [PATCH net-next 0/2] ntuple filters with RSS

[David Miller]

From: Edward Cree <ecree@solarflare.com>
Date: Mon, 26 Feb 2018 15:29:48 +0000

> This series introduces the ability to mark an ethtool steering filter to use
>  RSS spreading, and the ability to create and configure multiple RSS contexts
>  with different indirection tables, hash keys, and hash fields.
> An implementation for the sfc driver (for 7000-series and later SFC NICs) is
>  included in patch 2/2.
> 
> The anticipated use case of this feature is for steering traffic destined for
>  a container (or virtual machine) to the subset of CPUs on which processes in
>  the container (or the VM's vCPUs) are bound, while retaining the scalability
>  of RSS spreading from the viewpoint inside the container.
> The use of both a base queue number (ring_cookie) and indirection table is
>  intended to allow re-use of a single RSS context to target multiple sets of
>  CPUs.  For instance, if an 8-core system is hosting three containers on CPUs
>  [1,2], [3,4] and [6,7], then a single RSS context with an equal-weight [0,1]
>  indirection table could be used to target all three containers by setting
>  ring_cookie to 1, 3 and 6 on the respective filters.

The postings for this series didn't make it to the netdev list for some
reason, could you please resend?

Thank you.

Re: [PATCH net-next 0/2] ntuple filters with RSS

[David Miller]

From: Edward Cree <ecree@solarflare.com>
Date: Tue, 27 Feb 2018 16:10:07 +0000

> Hmm, this doesn't seem to have appeared in Patchwork.
> Do I need to resend?

Yes, see my other email.

Thank you.

Re: [PATCH net-next 0/2] ntuple filters with RSS

[Sowmini Varadhan]

On (02/27/18 11:49), David Miller wrote:
> > Do I need to resend?
> 
> Yes, see my other email.

do we need to resend patches not showing up in patchwork?
I recall seeing email about picking things manually from inbox
but missed this.

--Sowmini

Re: [PATCH net-next 0/2] ntuple filters with RSS

[David Miller]

From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Date: Tue, 27 Feb 2018 11:51:12 -0500

> On (02/27/18 11:49), David Miller wrote:
>> > Do I need to resend?
>> 
>> Yes, see my other email.
> 
> do we need to resend patches not showing up in patchwork?
> I recall seeing email about picking things manually from inbox
> but missed this.

Edward's patches didn't make it into patchwork because there
were syntax errors in his email headers and thus vger.kernel.org
was rejecting them outright.

I don't know what may or may not have happened for patches
you might be thinking about.

I'm expecting a V3 respin of your zerocopy notification changes
if that is what you're talking about, and I therefore marked
the most recent spin as "changes requested".

Re: [PATCH net-next 0/2] ntuple filters with RSS

[Sowmini Varadhan]

On (02/27/18 12:40), David Miller wrote:
> 
> I'm expecting a V3 respin of your zerocopy notification changes
> if that is what you're talking about, and I therefore marked
> the most recent spin as "changes requested".

sorry, I'm confused - you are waiting for V4?

I am not seeing v3 on patchwork, the only thing I see
is V2 (with "changes requested" as I expected).

V3 is archived here, and afaik needs no more respins:
 https://www.spinics.net/lists/netdev/msg485282.html

Willem had responded with
" For the series:
  Acked-by Willem de Bruijn <willemb@google.com>
  Small item I missed in v2: the recvmsg in patch 3 should fail hard with
  error() on an unexpected errno. Not worth sending a v4 just for that."

(see https://www.spinics.net/lists/netdev/msg485418.html)

Santosh had incorrectly flagged a smatch non-issue:
  https://www.spinics.net/lists/netdev/msg485424.html

I resent my patch a few minutes ago, but I suspect I may
now be hitting this well-known patchwork bug:
 https://www.spinics.net/lists/sparclinux/msg13787.html

Do I need to do something?

--Sowmini

Re: [PATCH net-next 0/2] ntuple filters with RSS

[David Miller]

From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Date: Tue, 27 Feb 2018 12:48:24 -0500

> Do I need to do something?

I don't see V3 in patchwork either, weird...

Please resend.  If it doesn't make it again I will take care of
it and diagnose.

Thank you, and sorry for this.