From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:57727 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751965AbeB0TpO (ORCPT ); Tue, 27 Feb 2018 14:45:14 -0500 Date: Tue, 27 Feb 2018 14:31:22 -0500 From: "John W. Linville" To: Jeff Kirsher Cc: linville@redhat.com, Jacob Keller , netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com, jogreene@redhat.com Subject: Re: [ethtool, 1/3] ethtool: correct display of VF when showing vf/queue filters Message-ID: <20180227193122.GB25950@tuxdriver.com> References: <20180226184956.15709-2-jeffrey.t.kirsher@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180226184956.15709-2-jeffrey.t.kirsher@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Feb 26, 2018 at 10:49:54AM -0800, Jeff Kirsher wrote: > From: Jacob Keller > > The original code that implemented this accidentally had an inverted > check, so it would never show the VF number properly. > > Fix this code to correctly display the VF number when we have one. > > Fixes: 36ee712b0fbc ("ethtool: support queue and VF fields for rxclass filters", 2017-03-23) > Signed-off-by: Jacob Keller > Tested-by: Andrew Bowers > Signed-off-by: Jeff Kirsher LGTM -- queued for ethtool-4.16... Thanks! John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.