From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: kubakici@wp.pl, idosch@idosch.org, jbenc@redhat.com,
idosch@mellanox.com, netdev@vger.kernel.org, jiri@mellanox.com,
dsahern@gmail.com, mlxsw@mellanox.com
Subject: Re: [PATCH net-next] team: Use extack to report enslavement failures
Date: Wed, 28 Feb 2018 09:28:34 -0500 (EST) [thread overview]
Message-ID: <20180228.092834.1580156018372298323.davem@davemloft.net> (raw)
In-Reply-To: <20180228071241.GC19654@nanopsycho>
From: Jiri Pirko <jiri@resnulli.us>
Date: Wed, 28 Feb 2018 08:12:41 +0100
> Wed, Feb 28, 2018 at 12:49:59AM CET, kubakici@wp.pl wrote:
>>On Tue, 27 Feb 2018 22:22:12 +0200, Ido Schimmel wrote:
>>> > If so, for how long? They should certainly be removed eventually. How
>>> > do we ensure we don't forget?
>>> >
>>> > Seems to me it would be better to remove them right now.
>>>
>>> I can do that unless someone objects.
>>
>>I don't object, but FWIW keep in mind extack errors don't show if
>>libmnl is not installed..
>
> Yeah, or if you have an older iproute2 package. I would keep the existing
> dmesg msgs for now. In the future, when everyone is used to exacks, then
> we can remove them.
That's how I feel about this as well.
next prev parent reply other threads:[~2018-02-28 14:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 15:38 [PATCH net-next] team: Use extack to report enslavement failures Ido Schimmel
2018-02-27 16:37 ` David Ahern
2018-02-27 19:42 ` Jiri Benc
2018-02-27 20:22 ` Ido Schimmel
2018-02-27 23:49 ` Jakub Kicinski
2018-02-28 7:12 ` Jiri Pirko
2018-02-28 7:21 ` Yuval Mintz
2018-02-28 8:58 ` Jiri Benc
2018-02-28 9:29 ` Jiri Pirko
2018-02-28 14:28 ` David Miller [this message]
2018-02-28 16:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180228.092834.1580156018372298323.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=idosch@idosch.org \
--cc=idosch@mellanox.com \
--cc=jbenc@redhat.com \
--cc=jiri@mellanox.com \
--cc=jiri@resnulli.us \
--cc=kubakici@wp.pl \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).