From: David Miller <davem@davemloft.net>
To: claudiu.manoil@nxp.com
Cc: netdev@vger.kernel.org, aspencer@spacex.com
Subject: Re: [PATCH net] gianfar: Fix Rx byte accounting for ndev stats
Date: Wed, 28 Feb 2018 10:59:50 -0500 (EST) [thread overview]
Message-ID: <20180228.105950.736675042430460251.davem@davemloft.net> (raw)
In-Reply-To: <1519745590-10569-1-git-send-email-claudiu.manoil@nxp.com>
From: Claudiu Manoil <claudiu.manoil@nxp.com>
Date: Tue, 27 Feb 2018 17:33:10 +0200
> Don't include in the Rx bytecount of the packet sent up the stack:
> the FCB (frame control block), and the padding bytes inserted by
> the controller into the frame payload, nor the FCS. All these are
> being pulled out of the skb by gfar_process_frame().
> This issue is old, likely from the driver's beginnings, however
> it was amplified by recent:
> commit d903ec77118c ("gianfar: simplify FCS handling and fix memory leak")
> which basically added the FCS to the Rx bytecount, and so brought
> this to my attention.
>
> Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
Applied, thank you.
prev parent reply other threads:[~2018-02-28 15:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 15:33 [PATCH net] gianfar: Fix Rx byte accounting for ndev stats Claudiu Manoil
2018-02-28 15:59 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180228.105950.736675042430460251.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aspencer@spacex.com \
--cc=claudiu.manoil@nxp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).