From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([184.105.139.130]:48218 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932230AbeB1P7w (ORCPT ); Wed, 28 Feb 2018 10:59:52 -0500 Date: Wed, 28 Feb 2018 10:59:50 -0500 (EST) Message-Id: <20180228.105950.736675042430460251.davem@davemloft.net> To: claudiu.manoil@nxp.com Cc: netdev@vger.kernel.org, aspencer@spacex.com Subject: Re: [PATCH net] gianfar: Fix Rx byte accounting for ndev stats From: David Miller In-Reply-To: <1519745590-10569-1-git-send-email-claudiu.manoil@nxp.com> References: <1519745590-10569-1-git-send-email-claudiu.manoil@nxp.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: Claudiu Manoil Date: Tue, 27 Feb 2018 17:33:10 +0200 > Don't include in the Rx bytecount of the packet sent up the stack: > the FCB (frame control block), and the padding bytes inserted by > the controller into the frame payload, nor the FCS. All these are > being pulled out of the skb by gfar_process_frame(). > This issue is old, likely from the driver's beginnings, however > it was amplified by recent: > commit d903ec77118c ("gianfar: simplify FCS handling and fix memory leak") > which basically added the FCS to the Rx bytecount, and so brought > this to my attention. > > Signed-off-by: Claudiu Manoil Applied, thank you.