Re: [net-next 1/1] tipc: sockopt(TIPC_SO_RCVBUF) for setting receive buffer

[David Miller <davem@davemloft.net>]

From: Jon Maloy <jon.maloy@ericsson.com>
Date: Tue, 27 Feb 2018 20:47:09 +0100

> From: Hoang Le <hoang.h.le@dektech.com.au>
> 
> We introduce a set/getsockopt for setting socket receive buffer per
> individual socket. This has turned out to sometimes be necessary for
> anycast and multicast receivers when used without flow control.
> 
> Signed-off-by: Hoang Le <hoang.h.le@dektech.com.au>
> Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>

I really don't want things to start going down this road.

The semantics for foo_rmem[] is that the [1] value indicates
the default on a new socket, and [2] determines how large
sk->sk_rcvbuf will grow through automatic receive buffer
autosizing as done by TCP.

It is not a limit value to impose upon the user's request.

Furthermore, the user can just do a SO_RCVBUF setsockopt to bypass
these limits.

So this change is undesirable on many levels.

I'm not applying this, sorry.  Please get TIPC sockets to behave
and enforce limits just like other socket families do, avoid
custom family specific behavior at all costs.

Thank you.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot