From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([184.105.139.130]:48870 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752728AbeB1Qmm (ORCPT ); Wed, 28 Feb 2018 11:42:42 -0500 Date: Wed, 28 Feb 2018 11:42:40 -0500 (EST) Message-Id: <20180228.114240.1711766040670948234.davem@davemloft.net> To: soheil.kdev@gmail.com Cc: netdev@vger.kernel.org, edumazet@google.com, willemb@google.com, soheil@google.com, ycheng@google.com, ncardwell@google.com Subject: Re: [PATCH net] tcp: purge write queue upon RST From: David Miller In-Reply-To: <20180227233218.158382-1-soheil.kdev@gmail.com> References: <20180227233218.158382-1-soheil.kdev@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: Soheil Hassas Yeganeh Date: Tue, 27 Feb 2018 18:32:18 -0500 > From: Soheil Hassas Yeganeh > > When the connection is reset, there is no point in > keeping the packets on the write queue until the connection > is closed. > > RFC 793 (page 70) and RFC 793-bis (page 64) both suggest > purging the write queue upon RST: > https://tools.ietf.org/html/draft-ietf-tcpm-rfc793bis-07 > > Moreover, this is essential for a correct MSG_ZEROCOPY > implementation, because userspace cannot call close(fd) > before receiving zerocopy signals even when the connection > is reset. > > Fixes: f214f915e7db ("tcp: enable MSG_ZEROCOPY") > Signed-off-by: Soheil Hassas Yeganeh > Reviewed-by: Eric Dumazet > Signed-off-by: Yuchung Cheng > Signed-off-by: Neal Cardwell This is one of those "yeah, why have we been doing this all of this time?" kind of situation. Let's hope there isn't some subtle side effect, but indeed this current behavior is broken for MSG_ZEROCOPY. Applied and queued up for -stable, thanks!