From: Sabrina Dubroca <sd@queasysnail.net>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Jianlin Shi <jishi@redhat.com>,
Stefano Brivio <sbrivio@redhat.com>,
David Ahern <dsahern@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ipv4: avoid unused variable warning for sysctl
Date: Wed, 28 Feb 2018 15:04:25 +0100 [thread overview]
Message-ID: <20180228140425.GA2577@bistromath.localdomain> (raw)
In-Reply-To: <20180228133310.1816221-1-arnd@arndb.de>
2018-02-28, 14:32:48 +0100, Arnd Bergmann wrote:
> The newly introudced ip_min_valid_pmtu variable is only used when
> CONFIG_SYSCTL is set:
>
> net/ipv4/route.c:135:12: error: 'ip_min_valid_pmtu' defined but not used [-Werror=unused-variable]
>
> This moves it to the other variables like it, to avoid the harmless
> warning.
>
> Fixes: c7272c2f1229 ("net: ipv4: don't allow setting net.ipv4.route.min_pmtu below 68")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Crap. Thanks, and sorry for the mess.
Acked-by: Sabrina Dubroca <sd@queasysnail.net>
--
Sabrina
next prev parent reply other threads:[~2018-02-28 14:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 13:32 [PATCH] net: ipv4: avoid unused variable warning for sysctl Arnd Bergmann
2018-02-28 14:04 ` Sabrina Dubroca [this message]
2018-03-01 18:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180228140425.GA2577@bistromath.localdomain \
--to=sd@queasysnail.net \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=jishi@redhat.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sbrivio@redhat.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).