From: David Miller <davem@davemloft.net>
To: mmanning@vyatta.mail-att.com
Cc: netdev@vger.kernel.org, dsahern@gmail.com
Subject: Re: [PATCH] net: allow interface to be set into vrf if a vif in same vrf
Date: Thu, 01 Mar 2018 13:28:24 -0500 (EST) [thread overview]
Message-ID: <20180301.132824.1050652529981791013.davem@davemloft.net> (raw)
In-Reply-To: <1519663736-28904-1-git-send-email-mmanning@vyatta.mail-att.com>
From: Mike Manning <mmanning@vyatta.mail-att.com>
Date: Mon, 26 Feb 2018 16:48:56 +0000
> Setting an interface into a vrf fails with 'RTNETLINK answers: File
> exists' if one of its vifs is already in the same vrf. As the vrf is an
> upper device of the vif, it is also showing up as an upper device of
> the interface itself. The solution is to restrict this check to devices
> other than master. As only one master device can be linked to a device,
> in this case the check is for the upper device (vrf) to be linked to as
> being the master device rather than any other upper device.
>
> Signed-off-by: Mike Manning <mmanning@att.com>
David A., please review.
next prev parent reply other threads:[~2018-03-01 18:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 16:48 [PATCH] net: allow interface to be set into vrf if a vif in same vrf Mike Manning
2018-02-26 16:53 ` David Ahern
2018-03-01 18:28 ` David Miller [this message]
2018-03-01 18:30 ` David Ahern
[not found] <61cddbff-8a2b-426e-9d43-29ab2ebb2493@mail.eng.vyatta.net>
[not found] ` <f1ba6938-588c-1deb-c5da-b698301759cf@vyatta.att-mail.com>
2018-02-26 20:43 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180301.132824.1050652529981791013.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=mmanning@vyatta.mail-att.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).