From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([184.105.139.130]:35932 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1033928AbeCAS20 (ORCPT ); Thu, 1 Mar 2018 13:28:26 -0500 Date: Thu, 01 Mar 2018 13:28:24 -0500 (EST) Message-Id: <20180301.132824.1050652529981791013.davem@davemloft.net> To: mmanning@vyatta.mail-att.com Cc: netdev@vger.kernel.org, dsahern@gmail.com Subject: Re: [PATCH] net: allow interface to be set into vrf if a vif in same vrf From: David Miller In-Reply-To: <1519663736-28904-1-git-send-email-mmanning@vyatta.mail-att.com> References: <1519663736-28904-1-git-send-email-mmanning@vyatta.mail-att.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: Mike Manning Date: Mon, 26 Feb 2018 16:48:56 +0000 > Setting an interface into a vrf fails with 'RTNETLINK answers: File > exists' if one of its vifs is already in the same vrf. As the vrf is an > upper device of the vif, it is also showing up as an upper device of > the interface itself. The solution is to restrict this check to devices > other than master. As only one master device can be linked to a device, > in this case the check is for the upper device (vrf) to be linked to as > being the master device rather than any other upper device. > > Signed-off-by: Mike Manning David A., please review.