From: David Miller <davem@davemloft.net>
To: mmanning@vyatta.mail-att.com
Cc: netdev@vger.kernel.org, dsahern@gmail.com
Subject: Re: [PATCH] net: allow interface to be set into VRF if VLAN interface in same VRF
Date: Thu, 01 Mar 2018 21:26:35 -0500 (EST) [thread overview]
Message-ID: <20180301.212635.783607434433134528.davem@davemloft.net> (raw)
In-Reply-To: <1519688970-19740-1-git-send-email-mmanning@vyatta.mail-att.com>
From: Mike Manning <mmanning@vyatta.mail-att.com>
Date: Mon, 26 Feb 2018 23:49:30 +0000
> Setting an interface into a VRF fails with 'RTNETLINK answers: File
> exists' if one of its VLAN interfaces is already in the same VRF.
> As the VRF is an upper device of the VLAN interface, it is also showing
> up as an upper device of the interface itself. The solution is to
> restrict this check to devices other than master. As only one master
> device can be linked to a device, the check in this case is that the
> upper device (VRF) being linked to is not the same as the master device
> instead of it not being any one of the upper devices.
>
> The following example shows an interface ens12 (with a VLAN interface
> ens12.10) being set into VRF green, which behaves as expected:
>
> # ip link add link ens12 ens12.10 type vlan id 10
> # ip link set dev ens12 master vrfgreen
> # ip link show dev ens12
> 3: ens12: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel
> master vrfgreen state UP mode DEFAULT group default qlen 1000
> link/ether 52:54:00:4c:a0:45 brd ff:ff:ff:ff:ff:ff
>
> But if the VLAN interface has previously been set into the same VRF,
> then setting the interface into the VRF fails:
>
> # ip link set dev ens12 nomaster
> # ip link set dev ens12.10 master vrfgreen
> # ip link show dev ens12.10
> 39: ens12.10@ens12: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500
> qdisc noqueue master vrfgreen state UP mode DEFAULT group default
> qlen 1000 link/ether 52:54:00:4c:a0:45 brd ff:ff:ff:ff:ff:ff
> # ip link set dev ens12 master vrfgreen
> RTNETLINK answers: File exists
>
> The workaround is to move the VLAN interface back into the default VRF
> beforehand, but it has to be shut first so as to avoid the risk of
> traffic leaking from the VRF. This fix avoids needing this workaround.
>
> Signed-off-by: Mike Manning <mmanning@att.com>
Applied, thanks Mike.
prev parent reply other threads:[~2018-03-02 2:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 23:49 [PATCH] net: allow interface to be set into VRF if VLAN interface in same VRF Mike Manning
2018-02-27 16:56 ` David Ahern
2018-03-02 2:26 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180301.212635.783607434433134528.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=mmanning@vyatta.mail-att.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).