From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:41118 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1164179AbeCBC2q (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 1 Mar 2018 21:28:46 -0500
Date: Thu, 01 Mar 2018 21:28:44 -0500 (EST)
Message-Id: <20180301.212844.469268023967788683.davem@davemloft.net>
To: soheil.kdev@gmail.com
Cc: netdev@vger.kernel.org, edumazet@google.com, willemb@google.com,
        soheil@google.com
Subject: Re: [PATCH net-next] socket: skip checking sk_err for
 recvmmsg(MSG_ERRQUEUE)
From: David Miller <davem@davemloft.net>
In-Reply-To: <20180227232240.145396-1-soheil.kdev@gmail.com>
References: <20180227232240.145396-1-soheil.kdev@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Soheil Hassas Yeganeh <soheil.kdev@gmail.com>
Date: Tue, 27 Feb 2018 18:22:40 -0500

> From: Soheil Hassas Yeganeh <soheil@google.com>
> 
> recvmmsg does not call ___sys_recvmsg when sk_err is set.
> That is fine for normal reads but, for MSG_ERRQUEUE, recvmmsg
> should always call ___sys_recvmsg regardless of sk->sk_err to
> be able to clear error queue. Otherwise, users are not able to
> drain the error queue using recvmmsg.
> 
> Signed-off-by: Soheil Hassas Yeganeh <soheil@google.com>
> Reviewed-by: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Willem de Bruijn <willemb@google.com>

Applied, thank you.