From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f196.google.com ([209.85.220.196]:41423 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161033AbeCATDd (ORCPT ); Thu, 1 Mar 2018 14:03:33 -0500 Received: by mail-qk0-f196.google.com with SMTP id w142so8920405qkb.8 for ; Thu, 01 Mar 2018 11:03:33 -0800 (PST) Date: Thu, 1 Mar 2018 16:03:29 -0300 From: Marcelo Ricardo Leitner To: Roman Mashak Cc: davem@davemloft.net, netdev@vger.kernel.org, jhs@mojatatu.com, jiri@resnulli.us, xiyou.wangcong@gmail.com Subject: Re: [PATCH 4/5] net sched actions: implement get_fill_size routine in act_gact Message-ID: <20180301190329.GD3887@localhost.localdomain> References: <1519929931-1119-1-git-send-email-mrv@mojatatu.com> <1519929931-1119-5-git-send-email-mrv@mojatatu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1519929931-1119-5-git-send-email-mrv@mojatatu.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Mar 01, 2018 at 01:45:30PM -0500, Roman Mashak wrote: > Signed-off-by: Roman Mashak > --- > net/sched/act_gact.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/net/sched/act_gact.c b/net/sched/act_gact.c > index 7456325..ee775ac 100644 > --- a/net/sched/act_gact.c > +++ b/net/sched/act_gact.c > @@ -217,6 +217,22 @@ static int tcf_gact_search(struct net *net, struct tc_action **a, u32 index, > return tcf_idr_search(tn, a, index); > } > > +static size_t tcf_gact_get_fill_size(const struct tc_action *act) > +{ > +#ifdef CONFIG_GACT_PROB > + struct tcf_gact *gact = to_gact(act); > + int prob_len = 0; > + > + if (gact->tcfg_ptype) > + prob_len = nla_total_size(sizeof(struct tc_gact_p)); > +#endif > + return nla_total_size(sizeof(struct tc_gact)) /* TCA_GACT_PARMS */ > +#ifdef CONFIG_GACT_PROB > + + prob_len /* TCA_GACT_PROB */ > +#endif > + ; > +} This is quite bad to the eye. What about: static size_t tcf_gact_get_fill_size(const struct tc_action *act) { size_t sz = nla_total_size(sizeof(struct tc_gact)); /* TCA_GACT_PARMS */ #ifdef CONFIG_GACT_PROB if (to_gact(act)->tcfg_ptype) sz += nla_total_size(sizeof(struct tc_gact_p)); /* TCA_GACT_PROB */ #endif return sz; } Should be the same, bug easier to read. > + > static struct tc_action_ops act_gact_ops = { > .kind = "gact", > .type = TCA_ACT_GACT, > @@ -227,6 +243,7 @@ static struct tc_action_ops act_gact_ops = { > .init = tcf_gact_init, > .walk = tcf_gact_walker, > .lookup = tcf_gact_search, > + .get_fill_size = tcf_gact_get_fill_size, > .size = sizeof(struct tcf_gact), > }; > > -- > 2.7.4 >