From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com ([66.111.4.29]:37581 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161376AbeCAThj (ORCPT ); Thu, 1 Mar 2018 14:37:39 -0500 Date: Thu, 1 Mar 2018 21:37:36 +0200 From: Ido Schimmel To: David Ahern Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, idosch@mellanox.com, jiri@mellanox.com Subject: Re: [PATCH net-next 3/5] selftests: forwarding: Handle 0 for packet difference in multipath tests Message-ID: <20180301193736.GC4839@splinter> References: <20180301190947.7299-1-dsahern@gmail.com> <20180301190947.7299-4-dsahern@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180301190947.7299-4-dsahern@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Mar 01, 2018 at 11:09:45AM -0800, David Ahern wrote: > If the packet stats have a difference of 0, the test output shows: > INFO: Expected ratio 2.00 Measured ratio > Runtime error (func=(main), adr=9): Divide by zero > (standard_in) 2: syntax error > (standard_in) 1: syntax error > ./router_multipath.sh: line 187: test: : integer expression expected > TEST: Multipath [FAIL] > Too large discrepancy between expected and measured ratios > > Handle the 0 and display a cleaner message: > INFO: Running IPv6 multipath tests > TEST: Multipath [FAIL] > Packet difference is 0 > > Signed-off-by: David Ahern Reviewed-by: Ido Schimmel Thanks!