From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx3.wp.pl ([212.77.101.10]:4207 "EHLO mx3.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1163301AbeCBDsv (ORCPT ); Thu, 1 Mar 2018 22:48:51 -0500 Date: Thu, 1 Mar 2018 19:48:40 -0800 From: Jakub Kicinski To: Alexander Aring Cc: Jiri Pirko , netdev@vger.kernel.org, nogahf@mellanox.com, yuvalm@mellanox.com, David Miller , idosch@mellanox.com, mlxsw@mellanox.com, Jamal Hadi Salim , Cong Wang , kernel@mojatatu.com Subject: Re: [patch net-next 09/10] net: sch: prio: Add offload ability for grafting a child Message-ID: <20180301194840.79a9a923@cakuba.netronome.com> In-Reply-To: References: <20180228094507.22354-1-jiri@resnulli.us> <20180228094507.22354-10-jiri@resnulli.us> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 1 Mar 2018 22:38:50 -0500, Alexander Aring wrote: > I guess to make extack working, you need to return an errno if failed. AFAIK extack is printed as a warning if operation did not fail.