netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Moritz Fischer <mdf@kernel.org>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	robh+dt@kernel.org, mark.rutland@arm.com, f.fainelli@gmail.com,
	davem@davemloft.net
Subject: Re: [RESEND PATCH v4 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev
Date: Thu, 1 Mar 2018 21:11:35 +0100	[thread overview]
Message-ID: <20180301201135.GA343@lunn.ch> (raw)
In-Reply-To: <20180301191547.2816-2-mdf@kernel.org>

Hi Moritz

> - Consistency for NIXGE_MDIO_CXX_READ constants

> +#define NIXGE_MDIO_CLAUSE45	BIT(12)
> +#define NIXGE_MDIO_CLAUSE22	0
> +#define NIXGE_MDIO_OP(n)     (((n) & 0x3) << 10)
> +#define NIXGE_MDIO_OP_ADDRESS	0
> +#define NIXGE_MDIO_OP_WRITE	BIT(0)
> +#define NIXGE_MDIO_C45_READ	(BIT(1) | BIT(0))
> +#define NIXGE_MDIO_C22_WRITE	BIT(0)
> +#define NIXGE_MDIO_C22_READ	BIT(1)

Thanks for making READ consistent. But what about WRITE?  I'd suggest
you don't just blindly follow comments, but think about them.

    Andrew

  reply	other threads:[~2018-03-01 20:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-01 19:15 [RESEND PATCH v4 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev Moritz Fischer
2018-03-01 19:15 ` [RESEND PATCH v4 2/2] net: ethernet: nixge: Add support " Moritz Fischer
2018-03-01 20:11   ` Andrew Lunn [this message]
2018-03-02  9:21 ` [RESEND PATCH v4 1/2] dt-bindings: net: Add bindings " Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180301201135.GA343@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mdf@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).